Bug 115857

Summary:

[BlackBerry] Style updates required based on new check-webkit-style

Product:

WebKit

Reporter:

Mike Fenton <mifenton>

Component:

WebKit BlackBerry

Assignee:

Mike Fenton <mifenton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch 1	none
Patch 2	none
Patch 3	none
Patch 4	none
Patch 5	rwlbuis: review+, commit-queue: commit-queue-
Patch 6	none
Patch 7	none
Patch 8	rwlbuis: review+, commit-queue: commit-queue-
Patch 9	none
Patch 10	none
Patch 11	none
Patch 12	none
Patch 13	none
Updated Patch 5 with new changelog.	none
Updated patch 8 with new changelog.	none

Mike Fenton

Reported 2013-05-09 06:08:03 PDT

This applies to a large number of unit files. All changes will be attached to this bug.

Attachments
Patch 1 (8.52 KB, patch) 2013-05-09 07:06 PDT, Mike Fenton	no flags	Details Formatted Diff Diff
Patch 2 (3.41 KB, patch) 2013-05-09 07:07 PDT, Mike Fenton	no flags	Details Formatted Diff Diff
Patch 3 (4.64 KB, patch) 2013-05-09 07:07 PDT, Mike Fenton	no flags	Details Formatted Diff Diff
Patch 4 (5.92 KB, patch) 2013-05-09 07:07 PDT, Mike Fenton	no flags	Details Formatted Diff Diff
Patch 5 (11.68 KB, patch) 2013-05-09 07:08 PDT, Mike Fenton	rwlbuis: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Patch 6 (12.08 KB, patch) 2013-05-09 07:08 PDT, Mike Fenton	no flags	Details Formatted Diff Diff
Patch 7 (6.13 KB, patch) 2013-05-09 07:09 PDT, Mike Fenton	no flags	Details Formatted Diff Diff
Patch 8 (10.03 KB, patch) 2013-05-09 07:09 PDT, Mike Fenton	rwlbuis: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Patch 9 (12.74 KB, patch) 2013-05-09 07:09 PDT, Mike Fenton	no flags	Details Formatted Diff Diff
Patch 10 (14.91 KB, patch) 2013-05-09 07:10 PDT, Mike Fenton	no flags	Details Formatted Diff Diff
Patch 11 (14.47 KB, patch) 2013-05-09 07:16 PDT, Mike Fenton	no flags	Details Formatted Diff Diff
Patch 12 (21.85 KB, patch) 2013-05-09 07:16 PDT, Mike Fenton	no flags	Details Formatted Diff Diff
Patch 13 (9.54 KB, patch) 2013-05-09 07:17 PDT, Mike Fenton	no flags	Details Formatted Diff Diff
Updated Patch 5 with new changelog. (11.27 KB, patch) 2013-05-09 11:22 PDT, Mike Fenton	no flags	Details Formatted Diff Diff
Updated patch 8 with new changelog. (10.00 KB, patch) 2013-05-09 11:24 PDT, Mike Fenton	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Mike Fenton

Comment 1 2013-05-09 07:06:39 PDT

Created attachment 201190 [details] Patch 1

Mike Fenton

Comment 2 2013-05-09 07:07:01 PDT

Created attachment 201192 [details] Patch 2

Mike Fenton

Comment 3 2013-05-09 07:07:24 PDT

Created attachment 201193 [details] Patch 3

Mike Fenton

Comment 4 2013-05-09 07:07:48 PDT

Created attachment 201194 [details] Patch 4

Mike Fenton

Comment 5 2013-05-09 07:08:08 PDT

Created attachment 201195 [details] Patch 5

Mike Fenton

Comment 6 2013-05-09 07:08:33 PDT

Created attachment 201196 [details] Patch 6

Mike Fenton

Comment 7 2013-05-09 07:09:00 PDT

Created attachment 201197 [details] Patch 7

Mike Fenton

Comment 8 2013-05-09 07:09:29 PDT

Created attachment 201198 [details] Patch 8

Mike Fenton

Comment 9 2013-05-09 07:09:51 PDT

Created attachment 201199 [details] Patch 9

Mike Fenton

Comment 10 2013-05-09 07:10:12 PDT

Created attachment 201200 [details] Patch 10

Mike Fenton

Comment 11 2013-05-09 07:16:29 PDT

Created attachment 201201 [details] Patch 11

Mike Fenton

Comment 12 2013-05-09 07:16:49 PDT

Created attachment 201202 [details] Patch 12

Mike Fenton

Comment 13 2013-05-09 07:17:11 PDT

Created attachment 201203 [details] Patch 13

Rob Buis

Comment 14 2013-05-09 07:27:37 PDT

Comment on attachment 201190 [details] Patch 1 Ok.

WebKit Commit Bot

Comment 15 2013-05-09 08:10:20 PDT

The commit-queue encountered the following flaky tests while processing attachment 201190 [details]: platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: rniwa@webkit.org) transitions/color-transition-rounding.html bug 114182 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: peter@chromium.org) transitions/interrupt-zero-duration.html bug 114184 (authors: cmarrin@apple.com, rniwa@webkit.org, and simon.fraser@apple.com) transitions/multiple-background-transitions.html bug 114185 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-color.html bug 114186 (author: peter@chromium.org) transitions/multiple-shadow-transitions.html bug 114187 (author: simon.fraser@apple.com) transitions/mismatched-shadow-transitions.html bug 114188 (author: simon.fraser@apple.com) transitions/color-transition-all.html bug 114189 (authors: ossy@webkit.org and simon.fraser@apple.com) transitions/negative-delay.html bug 114190 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: peter@chromium.org) transitions/min-max-width-height-transitions.html bug 114192 (author: simon.fraser@apple.com) transitions/cancel-transition.html bug 114193 (authors: ojan@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) transitions/border-radius-transition.html bug 114194 (author: simon.fraser@apple.com) transitions/flex-transitions.html bug 114195 (author: tony@chromium.org) transitions/mixed-type.html bug 114196 (author: mikelawther@chromium.org) transitions/multiple-mask-transitions.html bug 114197 (author: simon.fraser@apple.com) transitions/color-transition-premultiplied.html bug 114198 (author: simon.fraser@apple.com) transitions/mismatched-shadow-styles.html bug 114199 (author: simon.fraser@apple.com) transitions/mask-transitions.html bug 114200 (authors: ojan@chromium.org, oliver@apple.com, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-length.html bug 114201 (author: peter@chromium.org) transitions/multiple-background-size-transitions.html bug 114202 (authors: mitz@webkit.org and simon.fraser@apple.com) transitions/clip-transition.html bug 114203 (authors: dglazkov@chromium.org, krit@webkit.org, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-transform.html bug 114204 (author: peter@chromium.org) transitions/shorthand-border-transitions.html bug 114205 (authors: ojan@chromium.org and simon.fraser@apple.com) transitions/interrupted-accelerated-transition.html bug 56242 (authors: rniwa@webkit.org, simon.fraser@apple.com, and tonyg@chromium.org) transitions/background-transitions.html bug 114206 (author: simon.fraser@apple.com) http/tests/security/cookies/third-party-cookie-blocking-user-action.html bug 114511 (authors: ap@webkit.org, jochen@chromium.org, and rniwa@webkit.org) http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: abarth@webkit.org and rniwa@webkit.org) fast/loader/javascript-url-in-object.html bug 114210 (authors: rniwa@webkit.org and sam@webkit.org) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 16 2013-05-09 08:11:12 PDT

Comment on attachment 201190 [details] Patch 1 Clearing flags on attachment: 201190 Committed r149806: <http://trac.webkit.org/changeset/149806>

Rob Buis

Comment 17 2013-05-09 08:13:10 PDT

Comment on attachment 201192 [details] Patch 2 Ok.

Rob Buis

Comment 18 2013-05-09 08:13:31 PDT

Comment on attachment 201193 [details] Patch 3 Ok.

Rob Buis

Comment 19 2013-05-09 08:13:57 PDT

Comment on attachment 201194 [details] Patch 4 Ok.

WebKit Commit Bot

Comment 20 2013-05-09 08:25:23 PDT

Comment on attachment 201193 [details] Patch 3 Clearing flags on attachment: 201193 Committed r149808: <http://trac.webkit.org/changeset/149808>

WebKit Commit Bot

Comment 21 2013-05-09 08:34:26 PDT

Comment on attachment 201194 [details] Patch 4 Clearing flags on attachment: 201194 Committed r149809: <http://trac.webkit.org/changeset/149809>

WebKit Commit Bot

Comment 22 2013-05-09 08:42:37 PDT

Comment on attachment 201192 [details] Patch 2 Clearing flags on attachment: 201192 Committed r149811: <http://trac.webkit.org/changeset/149811>

Rob Buis

Comment 23 2013-05-09 08:50:37 PDT

Comment on attachment 201195 [details] Patch 5 Ok.

Rob Buis

Comment 24 2013-05-09 08:51:03 PDT

Comment on attachment 201196 [details] Patch 6 Ok.

Rob Buis

Comment 25 2013-05-09 08:51:22 PDT

Comment on attachment 201197 [details] Patch 7 Ok.

WebKit Commit Bot

Comment 26 2013-05-09 09:01:47 PDT

Comment on attachment 201197 [details] Patch 7 Clearing flags on attachment: 201197 Committed r149815: <http://trac.webkit.org/changeset/149815>

Rob Buis

Comment 27 2013-05-09 09:09:47 PDT

Comment on attachment 201198 [details] Patch 8 Ok.

WebKit Commit Bot

Comment 28 2013-05-09 09:13:23 PDT

Comment on attachment 201198 [details] Patch 8 Rejecting attachment 201198 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 201198, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: pp patching file Source/WebKit/blackberry/Api/WebPageCompositor.h patching file Source/WebKit/blackberry/Api/WebPageCompositor_p.h patching file Source/WebKit/blackberry/Api/WebSettings_p.h patching file Source/WebKit/blackberry/ChangeLog Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/ChangeLog.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Rob Buis']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/432027

WebKit Commit Bot

Comment 29 2013-05-09 09:15:48 PDT

Comment on attachment 201196 [details] Patch 6 Clearing flags on attachment: 201196 Committed r149818: <http://trac.webkit.org/changeset/149818>

Rob Buis

Comment 30 2013-05-09 09:23:42 PDT

Comment on attachment 201199 [details] Patch 9 LGTM.

Rob Buis

Comment 31 2013-05-09 09:24:57 PDT

Comment on attachment 201200 [details] Patch 10 Ok.

WebKit Commit Bot

Comment 32 2013-05-09 09:33:01 PDT

Comment on attachment 201195 [details] Patch 5 Rejecting attachment 201195 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 201195, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 0-ab3c-d52691b4dbfc ... Currently at 149814 = 96336ad83fb2e14bb1978c58c016b85743eac6d4 r149815 = f4080a7c3467212ef2e4e9f5f0170664a0448043 r149816 = 3c3b47e42a3622d93a955d3a7cbac5a44a06a529 r149817 = e32495936a230de179133a1d655fac20d1b46786 r149818 = 28fe0aa603f65f54a01877dc54a174a51258c1a9 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.appspot.com/results/408552

WebKit Commit Bot

Comment 33 2013-05-09 09:50:39 PDT

Comment on attachment 201199 [details] Patch 9 Clearing flags on attachment: 201199 Committed r149819: <http://trac.webkit.org/changeset/149819>

WebKit Commit Bot

Comment 34 2013-05-09 09:53:39 PDT

Comment on attachment 201200 [details] Patch 10 Clearing flags on attachment: 201200 Committed r149820: <http://trac.webkit.org/changeset/149820>

Rob Buis

Comment 35 2013-05-09 10:03:06 PDT

Comment on attachment 201195 [details] Patch 5 Retry.

WebKit Commit Bot

Comment 36 2013-05-09 10:03:52 PDT

Comment on attachment 201195 [details] Patch 5 Rejecting attachment 201195 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 201195, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: patch file(s). patching file Source/WebKit/blackberry/ChangeLog patching file Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp Hunk #3 FAILED at 385. 1 out of 9 hunks FAILED -- saving rejects to file Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp.rej patching file Source/WebKit/blackberry/WebKitSupport/SelectionHandler.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Rob Buis']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/433052

Rob Buis

Comment 37 2013-05-09 10:31:30 PDT

Comment on attachment 201201 [details] Patch 11 Ok.

Rob Buis

Comment 38 2013-05-09 10:31:57 PDT

Comment on attachment 201202 [details] Patch 12 Ok.

Rob Buis

Comment 39 2013-05-09 10:32:26 PDT

Comment on attachment 201203 [details] Patch 13 LGTM.

WebKit Commit Bot

Comment 40 2013-05-09 10:58:36 PDT

Comment on attachment 201201 [details] Patch 11 Clearing flags on attachment: 201201 Committed r149822: <http://trac.webkit.org/changeset/149822>

WebKit Commit Bot

Comment 41 2013-05-09 11:01:53 PDT

Comment on attachment 201203 [details] Patch 13 Clearing flags on attachment: 201203 Committed r149823: <http://trac.webkit.org/changeset/149823>

WebKit Commit Bot

Comment 42 2013-05-09 11:13:09 PDT

Comment on attachment 201202 [details] Patch 12 Clearing flags on attachment: 201202 Committed r149824: <http://trac.webkit.org/changeset/149824>

Mike Fenton

Comment 43 2013-05-09 11:22:11 PDT

Created attachment 201257 [details] Updated Patch 5 with new changelog.

Rob Buis

Comment 44 2013-05-09 11:23:08 PDT

Comment on attachment 201257 [details] Updated Patch 5 with new changelog. Ok.

Mike Fenton

Comment 45 2013-05-09 11:24:42 PDT

Created attachment 201258 [details] Updated patch 8 with new changelog.

WebKit Commit Bot

Comment 46 2013-05-09 11:24:51 PDT

Comment on attachment 201258 [details] Updated patch 8 with new changelog. Rejecting attachment 201258 [details] from review queue. mifenton@blackberry.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.

Rob Buis

Comment 47 2013-05-09 11:26:43 PDT

Comment on attachment 201258 [details] Updated patch 8 with new changelog. Ok.

WebKit Commit Bot

Comment 48 2013-05-09 11:32:07 PDT

Comment on attachment 201257 [details] Updated Patch 5 with new changelog. Clearing flags on attachment: 201257 Committed r149826: <http://trac.webkit.org/changeset/149826>

WebKit Commit Bot

Comment 49 2013-05-09 11:59:38 PDT

Comment on attachment 201258 [details] Updated patch 8 with new changelog. Clearing flags on attachment: 201258 Committed r149831: <http://trac.webkit.org/changeset/149831>

WebKit Commit Bot

Comment 50 2013-05-09 11:59:43 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.