Bug 114057

Summary: [GTK][AC] use a smart pointer for GList and ClutterCanvas
Product: WebKit Reporter: ChangSeok Oh <kevin.cs.oh>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gustavo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 105699    
Attachments:
Description Flags
Patch none

ChangSeok Oh
Reported 2013-04-05 13:00:11 PDT
We can make simple code & prevent possible memory leak by using smart pointer.
Attachments
Patch (3.94 KB, patch)
2013-04-05 13:12 PDT, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
ChangSeok Oh
Comment 1 2013-04-05 13:12:38 PDT
Created attachment 196672 [details] Patch
Gustavo Noronha (kov)
Comment 2 2013-04-11 06:55:15 PDT
Comment on attachment 196672 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196672&action=review > Source/WebCore/platform/graphics/clutter/GraphicsLayerActor.cpp:286 > + int width = std::max(static_cast<int>(ceilf(clutter_actor_get_width(actor))), 1); > + int height = std::max(static_cast<int>(ceilf(clutter_actor_get_height(actor))), 1); fwiw, I'm not sure this size or 1 is required with ClutterCanvas, might be worth checking.
WebKit Commit Bot
Comment 3 2013-04-11 07:40:46 PDT
Comment on attachment 196672 [details] Patch Clearing flags on attachment: 196672 Committed r148202: <http://trac.webkit.org/changeset/148202>
WebKit Commit Bot
Comment 4 2013-04-11 07:40:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.