Bug 112683

Summary: [BlackBerry] MathExtras: macros defined in math.h conflict with the real functions
Product: WebKit Reporter: Alberto Garcia <berto>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cgarcia, cmarcelo, commit-queue, ojan.autocc, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 111729    
Attachments:
Description Flags
Patch none

Alberto Garcia
Reported 2013-03-19 04:57:47 PDT
After calls to signbit and friends were prefixed with std:: in r143232, the BlackBerry port no longer compiles. The reason are the signbit / isnan / isinf / isfinite macros defined in math.h. They should be removed in order to use real functions instead.
Attachments
Patch (1.28 KB, patch)
2013-03-19 04:59 PDT, Alberto Garcia 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2013-03-19 04:59:46 PDT
Created attachment 193796 [details] Patch
Alberto Garcia
Comment 2 2013-04-05 01:07:18 PDT
Ping
WebKit Commit Bot
Comment 3 2013-04-08 18:26:21 PDT
Comment on attachment 193796 [details] Patch Clearing flags on attachment: 193796 Committed r147972: <http://trac.webkit.org/changeset/147972>
WebKit Commit Bot
Comment 4 2013-04-08 18:26:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.