Bug 112365

Summary: [BlackBerry] Enable USE_SYSTEM_MALLOC by default
Product: WebKit Reporter: Alberto Garcia <berto>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cgarcia, cmarcelo, dbates, ojan.autocc, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 111729    
Attachments:
Description Flags
Patch
none
Patch none

Alberto Garcia
Reported 2013-03-14 10:50:07 PDT
I'm getting lots of these otherwise: In file included from /home/berto/devel/code/webkit/Source/WTF/config.h:30:0, from /home/berto/devel/code/webkit/Source/WTF/wtf/HashTable.cpp:20: /home/berto/devel/code/webkit/Source/WTF/wtf/Platform.h:501:0: warning: "USE_SYSTEM_MALLOC" redefined [enabled by default] /home/berto/devel/code/webkit/WebKitBuild/armle-v7/Release/cmakeconfig.h:131:0: note: this is the location of the previous definition
Attachments
Patch (1.29 KB, patch)
2013-03-14 10:52 PDT, Alberto Garcia 		no flags
DetailsFormatted DiffDiff
Patch (2.43 KB, patch)
2013-03-18 10:44 PDT, Alberto Garcia 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2013-03-14 10:52:23 PDT
Created attachment 193150 [details] Patch
Alberto Garcia
Comment 2 2013-03-18 10:44:43 PDT
Created attachment 193600 [details] Patch Since there's the build option to enable/disable it, we don't need to hardcode its value in wtf/Platform.h
Benjamin Poulain
Comment 3 2013-03-18 12:20:03 PDT
Comment on attachment 193600 [details] Patch I guess you only build with build-webkit?
Alberto Garcia
Comment 4 2013-03-19 03:03:26 PDT
(In reply to comment #3) > (From update of attachment 193600 [details]) > I guess you only build with build-webkit? Exactly
WebKit Review Bot
Comment 5 2013-03-19 10:54:58 PDT
Comment on attachment 193600 [details] Patch Clearing flags on attachment: 193600 Committed r146222: <http://trac.webkit.org/changeset/146222>
WebKit Review Bot
Comment 6 2013-03-19 10:55:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.