Bug 109145

Summary: BUILD BREAKAGE (r142064): GCC does not support assigning std::nullptr to ChildProcessProxy pointer
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cdumez, dev, d-r, hausmann, jturcotte, kadam, mikhail.pozdnyakov, ossy, sam, tmpsantos, zarvai
Priority: P2 Keywords: MakingBotsRed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 107456, 108787    
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2013-02-07 00:36:30 PST
BUILD BREAKAGE (r142064): GCC does not support assigning std::nullptr to ChildProcessProxy pointer
Attachments
Patch (1.23 KB, patch)
2013-02-07 00:38 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-02-07 00:38:01 PST
Created attachment 187007 [details] Patch
Zan Dobersek
Comment 2 2013-02-07 00:51:46 PST
The patch is pretty straightforward, using 0 instead of std::nullptr. This seem to work on mac builds due to them using clang, while the failure occurs when using gcc. Given that the PST timezone is asleep at the moment (and will be for the next 8 hours or so) I'd recommend landing this ASAP just to remove the breakage and revisit this patch (possibly reverting it and fixing this another way) when the Apple folks get back online.
Csaba Osztrogonác
Comment 3 2013-02-07 01:03:17 PST
*** Bug 109148 has been marked as a duplicate of this bug. ***
Simon Hausmann
Comment 4 2013-02-07 01:25:44 PST
Comment on attachment 187007 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187007&action=review > Source/WebKit2/UIProcess/Downloads/DownloadProxyMap.cpp:76 > - m_process = nullptr; > + m_process = 0; Could it be that this file is just missing an include of <wtf/NullPtr.h>?
Philippe Normand
Comment 5 2013-02-07 01:27:02 PST
*** Bug 109153 has been marked as a duplicate of this bug. ***
Zan Dobersek
Comment 6 2013-02-07 01:33:00 PST
Fixed in r142082. http://trac.webkit.org/changeset/142082
Note You need to log in before you can comment on or make changes to this bug.