Bug 108975

Summary: [CSS Grid Layout] Grid item's logical height is not properly recomputed after -webkit-grid-column / -webkit-grid-row changes
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: Layout and RenderingAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, ojan.autocc, ojan, tony, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 103311    
Attachments:
Description Flags
Proposed fix: Add the missing clear logical height override. none

Julien Chaffraix
Reported 2013-02-05 13:13:11 PST
In RenderGrid::minContentForChild / maxContentForChild, we only set the containing block's override logical width: if (child->needsLayout()) { size_t columnTrack = resolveGridPosition(ForColumns, child); child->setOverrideContainingBlockContentLogicalWidth(columnTracks[columnTrack].m_usedBreadth); child->layout(); } This means that we can be reading a previous layout's containing block's override logical height! I would expect other part of the code to be wrong in the same way as we don't have any coverage of dynamic updates but this bug should solve that.
Attachments
Proposed fix: Add the missing clear logical height override. (12.21 KB, patch)
2013-02-05 14:22 PST, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2013-02-05 14:22:06 PST
Created attachment 186706 [details] Proposed fix: Add the missing clear logical height override.
Tony Chang
Comment 2 2013-02-05 14:36:05 PST
Comment on attachment 186706 [details] Proposed fix: Add the missing clear logical height override. Seems fine to me. This is similar to what we do in flexbox. You need to clear override sizes right before you layout.
WebKit Review Bot
Comment 3 2013-02-05 19:02:48 PST
Comment on attachment 186706 [details] Proposed fix: Add the missing clear logical height override. Clearing flags on attachment: 186706 Committed r141963: <http://trac.webkit.org/changeset/141963>
WebKit Review Bot
Comment 4 2013-02-05 19:02:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.