Bug 107457

Summary: [GTK] Implement resources API using injected bundle
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cgarcia, mrobinson, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 107456    
Attachments:
Description Flags
Patch sam: review+

Gustavo Noronha (kov)
Reported 2013-01-21 08:22:16 PST
The ResourceLoaderClient has been removed from WebKit2 in http://trac.webkit.org/changeset/140285 and its implementation has been removed from WebKit2GTK+ in http://trac.webkit.org/changeset/140337
Attachments
Patch (26.63 KB, patch)
2013-01-27 03:51 PST, Carlos Garcia Campos 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2013-01-21 08:53:48 PST
This also makes a bunch of tests that use WebResource fail: Tests that timed out (14): /WebKit2APITests/TestWebKitWebContext, /WebKit2APITests/TestWebViewEditor, /WebKit2APITests/TestWebExtensions, /WebKit2APITests/TestInspector, /WebKit2APITests/TestWebKitSettings, /WebKit2APITests/TestBackForwardList, /WebKit2APITests/TestWebKitWebView, /WebKit2APITests/TestWebKitPolicyClient, /WebKit2APITests/TestPrinting, /WebKit2APITests/TestLoaderClient, /WebKit2APITests/TestCookieManager, /WebKit2APITests/TestSSL, /WebKit2APITests/TestContextMenu, /WebKit2APITests/TestWebKitFindController
Carlos Garcia Campos
Comment 2 2013-01-22 00:34:42 PST
This will take a while to reimplement, I'll try to find the time . . .
Carlos Garcia Campos
Comment 3 2013-01-27 03:51:37 PST
Created attachment 184910 [details] Patch
WebKit Review Bot
Comment 4 2013-01-27 03:54:05 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Martin Robinson
Comment 5 2013-01-28 20:54:20 PST
FWIW, this looks good to me as well.
Carlos Garcia Campos
Comment 6 2013-01-29 04:03:24 PST
Committed r141096: <http://trac.webkit.org/changeset/141096>
Note You need to log in before you can comment on or make changes to this bug.