Bug 107145

Summary: [Chromium] Update some #includes in DumpRenderTree for headers in the new Platform directory
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: WebKit Misc.Assignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, haraken, jamesr, jochen, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 82948    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Mark Pilgrim (Google)
Reported 2013-01-17 11:09:20 PST
[Chromium] Update some #includes in DumpRenderTree for headers in the new Platform directory
Attachments
Patch (24.32 KB, patch)
2013-01-17 11:09 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (29.40 KB, patch)
2013-01-17 11:28 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (20.91 KB, patch)
2013-01-23 09:13 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2013-01-17 11:09:58 PST
Created attachment 183219 [details] Patch
Kentaro Hara
Comment 2 2013-01-17 11:13:07 PST
Comment on attachment 183219 [details] Patch ok
WebKit Review Bot
Comment 3 2013-01-17 11:13:29 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Kentaro Hara
Comment 4 2013-01-17 11:19:37 PST
Comment on attachment 183219 [details] Patch sorry, this requires review from API reviewers. pilgrim: would you set r? again?
Tony Chang
Comment 5 2013-01-17 11:23:55 PST
Comment on attachment 183219 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183219&action=review > Tools/DumpRenderTree/chromium/DRTDevToolsAgent.cpp:40 > +#include <public/WebCString.h> It's strange to me that 'public' is in the include path. Shouldn't it just be WebCString.h and have Source/Platform/chromium/public in the include path? I'm not sure why Source/Platform/chromium is in the include path.
jochen
Comment 6 2013-01-17 11:24:19 PST
Comment on attachment 183219 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183219&action=review > Tools/DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:34 > +#include <public/WebSettings.h> The headers in TestRunner/public need to specify the full path relative to Source/
Mark Pilgrim (Google)
Comment 7 2013-01-17 11:28:45 PST
Created attachment 183230 [details] Patch
Mark Pilgrim (Google)
Comment 8 2013-01-17 11:29:33 PST
Comment on attachment 183230 [details] Patch Reverted changes in chromium/TestRunner/public/
jochen
Comment 9 2013-01-17 12:00:05 PST
ChangeLog for Source/WebKit/chromium is missing?
Mark Pilgrim (Google)
Comment 10 2013-01-23 09:13:27 PST
Created attachment 184250 [details] Patch
Mark Pilgrim (Google)
Comment 11 2013-01-23 09:14:02 PST
Comment on attachment 184250 [details] Patch Removed spurious files outside Tools/DumpRenderTree from previous patch.
WebKit Review Bot
Comment 12 2013-01-23 11:57:05 PST
Comment on attachment 184250 [details] Patch Clearing flags on attachment: 184250 Committed r140565: <http://trac.webkit.org/changeset/140565>
WebKit Review Bot
Comment 13 2013-01-23 11:57:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.