Bug 106457

Summary: [Chromium] Remove idbFactory from WebKitPlatformSupport
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: WebKit Misc.Assignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, alecflett, dglazkov, dgrogan, enne, fishd, haraken, jamesr, jsbell, noel.gordon, peter+ews, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 107132, 108956    
Bug Blocks: 82948, 110262    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Mark Pilgrim (Google)
Reported 2013-01-09 07:35:32 PST
[Chromium] Remove idbFactory from WebKitPlatformSupport
Attachments
Patch (2.66 KB, patch)
2013-01-09 07:37 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (2.62 KB, patch)
2013-01-09 20:06 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (2.59 KB, patch)
2013-01-10 17:29 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (2.53 KB, patch)
2013-02-05 09:18 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (2.56 KB, patch)
2013-02-19 12:30 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2013-01-09 07:37:58 PST
Created attachment 181924 [details] Patch
WebKit Review Bot
Comment 2 2013-01-09 07:40:13 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
WebKit Review Bot
Comment 3 2013-01-09 07:44:32 PST
Comment on attachment 181924 [details] Patch Attachment 181924 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15771537
Mark Pilgrim (Google)
Comment 4 2013-01-09 07:55:51 PST
Looks like we need to wait for some Chromium changes to sync upstream first. Removing review flag until that happens.
Peter Beverloo (cr-android ews)
Comment 5 2013-01-09 08:19:04 PST
Comment on attachment 181924 [details] Patch Attachment 181924 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15754787
Adam Barth
Comment 6 2013-01-09 12:38:24 PST
You probably need to increase the chromium_rev in this file: http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/DEPS#L35 Usually we do that in a separate patch.
Mark Pilgrim (Google)
Comment 7 2013-01-09 20:06:32 PST
Created attachment 182052 [details] Patch
WebKit Review Bot
Comment 8 2013-01-09 20:33:51 PST
Comment on attachment 182052 [details] Patch Attachment 182052 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15775613
Peter Beverloo (cr-android ews)
Comment 9 2013-01-09 20:52:46 PST
Comment on attachment 182052 [details] Patch Attachment 182052 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15775618
Mark Pilgrim (Google)
Comment 10 2013-01-10 17:29:18 PST
Created attachment 182228 [details] Patch
Mark Pilgrim (Google)
Comment 11 2013-01-10 17:30:05 PST
Comment on attachment 182228 [details] Patch Indeed it was a DEPS problem, and it appears that someone else has resolved it in the meantime. http://trac.webkit.org/changeset/139347/trunk/Source/WebKit/chromium/DEPS So, resubmitting same patch.
noel gordon
Comment 12 2013-01-10 23:37:49 PST
This appears to be crashing a truck load of storage tests on cr-linux bot.
Mark Pilgrim (Google)
Comment 13 2013-02-05 09:18:15 PST
Created attachment 186642 [details] Patch
WebKit Review Bot
Comment 14 2013-02-05 09:44:22 PST
Comment on attachment 186642 [details] Patch Clearing flags on attachment: 186642 Committed r141896: <http://trac.webkit.org/changeset/141896>
WebKit Review Bot
Comment 15 2013-02-05 09:44:27 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 16 2013-02-05 10:28:36 PST
Re-opened since this is blocked by bug 108956
Mark Pilgrim (Google)
Comment 17 2013-02-19 12:30:29 PST
Created attachment 189141 [details] Patch
Mark Pilgrim (Google)
Comment 18 2013-02-19 12:31:44 PST
Comment on attachment 189141 [details] Patch Same patch, applied to ToT. Now that https://codereview.chromium.org/12230054 has landed, this no longer crashes LayoutTests/http/tests/security/*indexeddb*
WebKit Review Bot
Comment 19 2013-02-19 14:04:28 PST
Comment on attachment 189141 [details] Patch Clearing flags on attachment: 189141 Committed r143382: <http://trac.webkit.org/changeset/143382>
WebKit Review Bot
Comment 20 2013-02-19 14:04:34 PST
All reviewed patches have been landed. Closing bug.
Adrienne Walker
Comment 21 2013-02-19 16:22:06 PST
Reverted r143382 for reason: Breaks Chromium win/mac canary compilation Committed r143403: <http://trac.webkit.org/changeset/143403>
Adrienne Walker
Comment 22 2013-02-19 16:23:30 PST
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder/builds/40413/steps/compile/logs/stdio In file included from ../../webkit/tools/test_shell/test_shell_mac.mm:41: ../../webkit/tools/test_shell/test_shell_webkit_init.h:76:34:error: 'idbFactory' marked 'override' but does not override any member functions virtual WebKit::WebIDBFactory* idbFactory() OVERRIDE;
Adam Barth
Comment 23 2013-02-19 20:44:10 PST
We shouldn't ever use OVERRIDE when subclassing the WebKit API. It just leads to this sort of pain...
Mark Pilgrim (Google)
Comment 24 2013-02-20 06:00:10 PST
(In reply to comment #23) > We shouldn't ever use OVERRIDE when subclassing the WebKit API. It just leads to this sort of pain... I removed a bunch of them a few weeks ago, but this one was in test_shell and I missed it last time. Anyway, https://codereview.chromium.org/12320002/ will fix it then I'll re-submit this patch.
Mark Pilgrim (Google)
Comment 25 2013-02-20 09:28:25 PST
Comment on attachment 189141 [details] Patch Fixed downstream issue, roll led DEPS. Can we just resubmit this attachment or do I need to reupload the same patch again?
Adam Barth
Comment 26 2013-02-20 09:36:31 PST
Comment on attachment 189141 [details] Patch We can just resubmit.
WebKit Review Bot
Comment 27 2013-02-20 10:23:21 PST
Comment on attachment 189141 [details] Patch Clearing flags on attachment: 189141 Committed r143473: <http://trac.webkit.org/changeset/143473>
WebKit Review Bot
Comment 28 2013-02-20 10:23:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.