Bug 106227

Summary: [Chromium] Update some #includes in WebKit/chromium/public/ for new Platform directory
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: WebKit Misc.Assignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: abarth, dglazkov, eric.carlson, feature-media-reviews, fishd, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 82948    
Attachments:
Description Flags
WIP Patch
none
WIP Patch
none
Patch none

Mark Pilgrim (Google)
Reported 2013-01-07 09:34:23 PST
[Chromium] Update some #includes in WebKit/chromium/public/ for new Platform directory
Attachments
WIP Patch (85.98 KB, patch)
2013-01-07 09:43 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
WIP Patch (89.68 KB, patch)
2013-01-07 10:13 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (80.04 KB, patch)
2013-01-09 11:20 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2013-01-07 09:43:19 PST
Created attachment 181513 [details] WIP Patch
Mark Pilgrim (Google)
Comment 2 2013-01-07 10:13:34 PST
Created attachment 181519 [details] WIP Patch
Mark Pilgrim (Google)
Comment 3 2013-01-09 11:20:00 PST
Created attachment 181955 [details] Patch
Mark Pilgrim (Google)
Comment 4 2013-01-09 11:21:09 PST
Comment on attachment 181955 [details] Patch Shouldn't break Chromium compilation downstream, now that https://codereview.chromium.org/11748018/ has landed.
WebKit Review Bot
Comment 5 2013-01-09 11:21:37 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
WebKit Review Bot
Comment 6 2013-01-09 12:45:46 PST
Comment on attachment 181955 [details] Patch Clearing flags on attachment: 181955 Committed r139227: <http://trac.webkit.org/changeset/139227>
WebKit Review Bot
Comment 7 2013-01-09 12:45:50 PST
All reviewed patches have been landed. Closing bug.
Dimitri Glazkov (Google)
Comment 8 2013-01-10 08:43:56 PST
Did this break the Win builders? http://build.chromium.org/p/chromium.webkit/waterfall?builder=Win+Builder
Dimitri Glazkov (Google)
Comment 9 2013-01-10 08:52:37 PST
Also http://build.chromium.org/p/chromium.webkit/waterfall?builder=Win7+(dbg)
Dimitri Glazkov (Google)
Comment 10 2013-01-10 09:28:47 PST
Reverted r139227 for reason: Broke Win component build. Committed r139323: <http://trac.webkit.org/changeset/139323>
Mark Pilgrim (Google)
Comment 11 2013-01-23 14:49:19 PST
*** This bug has been marked as a duplicate of bug 107741 ***
Note You need to log in before you can comment on or make changes to this bug.