Bug 103669

Created attachment 176816 [details] Patch

Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

Comment on attachment 176816 [details] Patch Attachment 176816 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15059073 New failing tests: webintents/web-intents-delivery.html fast/dom/navigator-detached-no-crash.html webintents/web-intents-reload.html webintents/web-intents-api.html webintents/web-intents-delivery-reuse.html webintents/web-intents-invoke-port.html webintents/web-intents-invoke.html webintents/web-intents-failure.html webintents/web-intents-obj-constructor.html webintents/web-intents-reply.html

Created attachment 177271 [details] Patch

Made runtime-disable on by default to make sure tests run and pass still.

Comment on attachment 177271 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177271&action=review > Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h:262 > + static bool webKitIntentEnabled() { return isWebIntentsEnabled; } This method looks duplicated from the line above.

Comment on attachment 177271 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177271&action=review >> Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h:262 >> + static bool webKitIntentEnabled() { return isWebIntentsEnabled; } > > This method looks duplicated from the line above. never mind, the case is different :)

Comment on attachment 177271 [details] Patch Rejecting attachment 177271 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: 380 with fuzz 2 (offset 18 lines). patching file Source/WebKit/chromium/public/WebRuntimeFeatures.h Hunk #1 FAILED at 157. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/public/WebRuntimeFeatures.h.rej patching file Source/WebKit/chromium/src/WebRuntimeFeatures.cpp Hunk #1 succeeded at 667 (offset 28 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Darin Fish..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15133653

Comment on attachment 177271 [details] Patch Sigh. I moved the bot to git.webkit.org

Comment on attachment 177271 [details] Patch Rejecting attachment 177271 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: 380 with fuzz 2 (offset 18 lines). patching file Source/WebKit/chromium/public/WebRuntimeFeatures.h Hunk #1 FAILED at 157. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/public/WebRuntimeFeatures.h.rej patching file Source/WebKit/chromium/src/WebRuntimeFeatures.cpp Hunk #1 succeeded at 667 (offset 28 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Darin Fish..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15138442

Oh, this is a legit "does not apply" failure.

Created attachment 177780 [details] Patch

Yep. Should be merged to head in latest patch now.

Comment on attachment 177780 [details] Patch Clearing flags on attachment: 177780 Committed r136785: <http://trac.webkit.org/changeset/136785>

All reviewed patches have been landed. Closing bug.