Bug 101706

Summary: [Qt] r133953 broke the ARM_TRADITIONAL build
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Blocker CC: fpizlo, gaborb, galpeter, loki, milian.wolff, oliver, ossy, rgabor, webkit.review.bot, zherczeg
Priority: P1 Keywords: Qt, QtTriaged
Version: 420+   
Hardware: All   
OS: All   
Bug Depends on: 101757, 101832    
Bug Blocks: 98606    
Attachments:
Description Flags
Fix
none
Patch none

Csaba Osztrogonác
Reported 2012-11-08 21:53:56 PST
http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Build%29/builds/14679/steps/compile-webkit/logs/stdio from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/dfg/DFGJITCompiler.cpp:35: /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h: In member function 'JSC::AbstractMacroAssembler<JSC::ARMAssembler>::Call JSC::DFG::SpeculativeJIT::callOperation(JSC::DFG::J_DFGOperation_EDA, JSC::DFG::GPRReg, JSC::DFG::GPRReg, JSC::DFG::FPRReg, JSC::DFG::GPRReg)': /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:1676:53: error: no matching function for call to 'JSC::DFG::JITCompiler::setupArgumentsWithExecState(JSC::DFG::FPRReg&, JSC::DFG::GPRReg&)' ... and 1686:90, 1844:59, 1854:96
Attachments
Fix (1.84 KB, patch)
2012-11-09 00:12 PST, Gabor Ballabas 		no flags
DetailsFormatted DiffDiff
Patch (2.50 KB, patch)
2012-11-09 07:57 PST, Gabor Ballabas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gabor Ballabas
Comment 1 2012-11-09 00:12:51 PST
Created attachment 173221 [details] Fix
Milian Wolff
Comment 2 2012-11-09 04:34:47 PST
Thanks, that works for me.
Csaba Osztrogonác
Comment 3 2012-11-09 04:37:27 PST
Comment on attachment 173221 [details] Fix LGTM, rs=me
WebKit Review Bot
Comment 4 2012-11-09 04:41:56 PST
Comment on attachment 173221 [details] Fix Clearing flags on attachment: 173221 Committed r134051: <http://trac.webkit.org/changeset/134051>
WebKit Review Bot
Comment 5 2012-11-09 04:42:00 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 6 2012-11-09 06:47:20 PST
(In reply to comment #4) > (From update of attachment 173221 [details]) > Clearing flags on attachment: 173221 > > Committed r134051: <http://trac.webkit.org/changeset/134051> The build still fails: http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Build%29/builds/14736/steps/compile-webkit/logs/stdio
WebKit Review Bot
Comment 7 2012-11-09 06:47:33 PST
Re-opened since this is blocked by bug 101757
Csaba Osztrogonác
Comment 8 2012-11-09 07:13:31 PST
build error with the patch: /home/oszi/WebKit/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:1676:53: error: no matching function for call to 'JSC::DFG::JITCompiler::setupArgumentsWithExecState(JSC::DFG::FPRReg&, JSC::DFG::GPRReg&)' /home/oszi/WebKit/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:1844:59: error: no matching function for call to 'JSC::DFG::JITCompiler::setupArgumentsWithExecState(JSC::DFG::GPRReg&, JSC::DFG::GPRReg&, JSC::DFG::FPRReg&)'
Gabor Ballabas
Comment 9 2012-11-09 07:57:47 PST
Created attachment 173310 [details] Patch Fix for both hardfp and softfp.
Csaba Osztrogonác
Comment 10 2012-11-09 07:59:16 PST
Comment on attachment 173310 [details] Patch LGTM, r=me. I'll land it manually.
Csaba Osztrogonác
Comment 11 2012-11-09 08:03:21 PST
Comment on attachment 173310 [details] Patch Clearing flags on attachment: 173310 Committed r134071: <http://trac.webkit.org/changeset/134071>
Csaba Osztrogonác
Comment 12 2012-11-09 08:03:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.