Bug 10165
| Summary: | Vox: Master Bug | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Lucas Wagner <lucas> |
| Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Major | CC: | ap, banti17997, chezsmithy, justin.garcia, juwahrichard, kateshrestha, kocharaj111, mrowe, nomozine, rocky_1444, webkit |
| Priority: | P2 | Keywords: | NeedsReduction |
| Version: | 420+ | ||
| Hardware: | Mac | ||
| OS: | OS X 10.4 | ||
| URL: | http://www.vox.com/compose/ | ||
| Bug Depends on: | 12250, 11826, 12920, 12921, 12922, 13116 | ||
| Bug Blocks: | |||
Lucas Wagner
The "compose" feature of blog site Vox doesn't work fully under WebKit/Safari; there's some level of functionality, but some features (insertion of media, strikethrough, select all, etc.) don't work as expected.
Note: since Vox is currently an invite-only service, I've created an account for anyone wishing to investigate this:
Email: heylukee@gmail.com
Password: webkit
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Lucas Wagner
After downloading the latest build, things are much better; resizing text seems to be the only thing not yet working.
Alexey Proskuryakov
Also, text alignment doesn't seem to work.
Shawn Smith
Can we get this put on the "Compatibility Hit List"?
Other issues I see:
No way to move images which are inserted using cut and paste. Using Firefox you can drag the images within the text.
Shawn Smith
Did some investigation and found these two errors in the java script console. Probrably going to be more but this might get an investigation started?? I noted the error and the code snipit it occured in. The <<<< desigates the line where the error occured.
ERROR #1: Null Value Error
this.savedSelection = selection.getRangeAt(0).cloneRange();
saveSelection:function(){
var selection = this.getSelection();
if(selection.createRange){
var range = selection.createRange();
if(range.parentElement){
var element = range.parentElement();
if(element && element.ownerDocument === this.document)
this.savedSelection = range.getBookmark();
}
}else if(selection.getRangeAt)
this.savedSelection = selection.getRangeAt(0).cloneRange(); <<<<
},
ERROR#2: Value undefined (result of expression selection.removeAllRanges() is not object.
selection.removeAllRanges();
restoreSelection:function(){
this.focus();
if(!this.savedSelection)
return;
var selection = this.getSelection();
if(selection.createRange){
var range = this.document.body.createTextRange();
range.moveToBookmark(this.savedSelection);
range.select();
}else if(selection.getRangeAt){
selection.removeAllRanges(); <<<<
selection.addRange(this.savedSelection);
}
this.savedSelection = null;
this.logSelection();
},
Shawn Smith
Suggest changing the name of this bug from "Compose Feature of Vox does not work" to "Compose new Blog Post on Vox is broken in Safari".
Also suggest changing the Component to HTML DOM.
Finally, suggest a higher severity given the number of VOX users who are negatively impacted who use OS X.
Mark Rowe (bdash)
Trying to track this as a single "This big and complex JavaScript site doesn't work" is impractical. The issues that make it "broken" really need to be filed as separate bugs, and reduced so that they can be resolved independently.
Shawn Smith
Ok agreed. I will start opening a series of individual issues and link them here. Thanks for helping to get this some attention.
Mark Rowe (bdash)
It would be ideal to use this as a master bug to track the functionality of Vox. Put the new bug numbers into the "Bug 10165 depends on:" field to track them as dependencies of this bug.
Shawn Smith
Bug 11826 (Lack of removeAllRanges() support in Webkit) has been opened. It should be linked as a dependency.
Mark Rowe (bdash)
Shawn, you should be able to mark it as a dependency by putting the bug number in the "Bug 10165 depends on" field above the "Additional Comments" text area.
Justin Garcia
Re-titling as composing in Vox is no longer "broken". Adding a subtask to cover the control selections issue.
Alexey Proskuryakov
Not actionable after 15 years, closing.