Bug 101306

Summary: [Shadow] Use setPseudo() instead of setShadowPseudoId()
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, gtk-ews, gustavo, mifenton, tkent, webcomponents-bugzilla, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 101171, 101533    
Attachments:
Description Flags
WIP
none
WIP
none
Patch none

Shinya Kawanaka
Reported 2012-11-05 22:45:27 PST
We would like to remove shadowPseudoId() and setShadowPseudoId() (Bug 101171). In this bug, we would like to remove setShadowPseudoId() and use setPseudo instead.
Attachments
WIP (22.21 KB, patch)
2012-11-06 00:11 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
WIP (21.17 KB, patch)
2012-11-06 21:22 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (22.16 KB, patch)
2012-11-06 23:00 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-11-06 00:11:22 PST
Created attachment 172503 [details] WIP
Build Bot
Comment 2 2012-11-06 01:46:37 PST
Comment on attachment 172503 [details] WIP Attachment 172503 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14745300
Build Bot
Comment 3 2012-11-06 02:48:24 PST
Comment on attachment 172503 [details] WIP Attachment 172503 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14747354
kov's GTK+ EWS bot
Comment 4 2012-11-06 02:59:00 PST
Comment on attachment 172503 [details] WIP Attachment 172503 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/14660481
Shinya Kawanaka
Comment 5 2012-11-06 21:22:53 PST
Created attachment 172713 [details] WIP
Build Bot
Comment 6 2012-11-06 22:09:25 PST
Comment on attachment 172713 [details] WIP Attachment 172713 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14761205
Build Bot
Comment 7 2012-11-06 22:26:19 PST
Comment on attachment 172713 [details] WIP Attachment 172713 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14763078
Shinya Kawanaka
Comment 8 2012-11-06 23:00:26 PST
Created attachment 172723 [details] Patch
Kent Tamura
Comment 9 2012-11-07 00:48:57 PST
Comment on attachment 172723 [details] Patch Looks ok
WebKit Review Bot
Comment 10 2012-11-07 06:13:57 PST
Comment on attachment 172723 [details] Patch Clearing flags on attachment: 172723 Committed r133749: <http://trac.webkit.org/changeset/133749>
WebKit Review Bot
Comment 11 2012-11-07 06:14:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.