Bug 101171

Summary: [Shadow][Refactoring] Remove shadowPseudoId() and use pseudo() instead
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Web Components Team <webcomponents-bugzilla>
Status: RESOLVED WONTFIX    
Severity: Normal CC: allan.jensen, cmarcelo, eric.carlson, feature-media-reviews, gtk-ews, gustavo, macpherson, menard, mifenton, philn, rniwa, tkent, webcomponents-bugzilla, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 101306, 101702, 101703, 101707, 101708, 101709, 101714, 101881, 101906    
Bug Blocks: 97279    
Attachments:
Description Flags
WIP
none
WIP buildbot: commit-queue-

Shinya Kawanaka
Reported 2012-11-04 17:36:45 PST
We would like to remove shadowPseudoId() and use pseudo() instead.
Attachments
WIP (69.05 KB, patch)
2012-11-05 17:59 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
WIP (72.28 KB, patch)
2012-11-05 20:12 PST, Shinya Kawanaka 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-11-05 17:59:33 PST
Created attachment 172460 [details] WIP
Build Bot
Comment 2 2012-11-05 19:28:19 PST
Comment on attachment 172460 [details] WIP Attachment 172460 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14726818
Build Bot
Comment 3 2012-11-05 20:06:04 PST
Comment on attachment 172460 [details] WIP Attachment 172460 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14691306
Shinya Kawanaka
Comment 4 2012-11-05 20:12:22 PST
Created attachment 172475 [details] WIP
Kent Tamura
Comment 5 2012-11-05 20:20:07 PST
Comment on attachment 172475 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=172475&action=review > Source/WebCore/html/ColorInputType.cpp:121 > - wrapperElement->setShadowPseudoId("-webkit-color-swatch-wrapper"); > + wrapperElement->setPseudo("-webkit-color-swatch-wrapper"); nit: If you have enough time, I recommend to use AtomicString("-webkit-color-swatch-wrapper", AtomicString::ConstructFromLiteral) http://trac.webkit.org/wiki/EfficientStrings > Source/WebCore/html/FileInputType.cpp:86 > -const AtomicString& UploadButtonElement::shadowPseudoId() const > +const AtomicString& UploadButtonElement::pseudo() const > { > DEFINE_STATIC_LOCAL(AtomicString, pseudoId, ("-webkit-file-upload-button")); > return pseudoId; Overriding "pseudo" looks strange. Why don't you convert such code to setPseudo?
Shinya Kawanaka
Comment 6 2012-11-05 21:13:05 PST
(In reply to comment #5) > (From update of attachment 172475 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172475&action=review > > > Source/WebCore/html/ColorInputType.cpp:121 > > - wrapperElement->setShadowPseudoId("-webkit-color-swatch-wrapper"); > > + wrapperElement->setPseudo("-webkit-color-swatch-wrapper"); > > nit: If you have enough time, I recommend to use AtomicString("-webkit-color-swatch-wrapper", AtomicString::ConstructFromLiteral) > http://trac.webkit.org/wiki/EfficientStrings > > > Source/WebCore/html/FileInputType.cpp:86 > > -const AtomicString& UploadButtonElement::shadowPseudoId() const > > +const AtomicString& UploadButtonElement::pseudo() const > > { > > DEFINE_STATIC_LOCAL(AtomicString, pseudoId, ("-webkit-file-upload-button")); > > return pseudoId; > > Overriding "pseudo" looks strange. Why don't you convert such code to setPseudo? I'll convert them... since pseudo() is not virtual at all.
Build Bot
Comment 7 2012-11-05 21:27:59 PST
Comment on attachment 172475 [details] WIP Attachment 172475 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14725877
Shinya Kawanaka
Comment 8 2012-11-05 22:36:07 PST
Since we have a lot of places to be replaced, I would like to split this to several patches...
kov's GTK+ EWS bot
Comment 9 2012-11-05 23:16:54 PST
Comment on attachment 172475 [details] WIP Attachment 172475 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/14731694
Build Bot
Comment 10 2012-11-05 23:34:12 PST
Comment on attachment 172475 [details] WIP Attachment 172475 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14665460
Ryosuke Niwa
Comment 11 2019-10-04 22:19:23 PDT
We're not gonna do this. V1 API allows ::part, which is distant from pseudo element mechanism.
Note You need to log in before you can comment on or make changes to this bug.