Bug 101071

Summary: [CSS Shaders] Remove the dependency on CustomFilterValidatedProgram from CustomFilterRenderer
Product: WebKit Reporter: Alexandru Chiculita <achicu>
Component: Layout and RenderingAssignee: Alexandru Chiculita <achicu>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, dongseong.hwang, mvujovic, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 100905    
Bug Blocks: 98990    
Attachments:
Description Flags
Patch V1 dino: review+, achicu: commit-queue-

Alexandru Chiculita
Reported 2012-11-02 10:51:59 PDT
The idea is to make CustomFilterRenderer reusable in the UI process of WebKit2, so we need to remove the need of a CustomFilterValidatedProgram. On the UI process the program is already validated and is stored as a WebCustomFilterProgram. In that case we just need a CustomFilterCompiledProgramProvider. CustomFilterValidatedProgram and WebCustomFilterProgram will both implement that interface and will be able to compile the program when needed.
Attachments
Patch V1 (11.98 KB, patch)
2012-11-07 09:31 PST, Alexandru Chiculita 		dino: review+
achicu: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexandru Chiculita
Comment 1 2012-11-07 09:31:43 PST
Created attachment 172822 [details] Patch V1
Dean Jackson
Comment 2 2012-11-07 11:02:47 PST
Comment on attachment 172822 [details] Patch V1 View in context: https://bugs.webkit.org/attachment.cgi?id=172822&action=review > Source/WebCore/ChangeLog:9 > + used to delay the compilation of the shader until it was really needed. Instead, the FitlerEffectRenderer Typo: Fitler > Source/WebCore/platform/graphics/filters/CustomFilterRenderer.cpp:122 > + if (!m_compiledProgram.get() || !m_compiledProgram->isInitialized()) You can just do !m_compiledProgram rather than adding .get()
Alexandru Chiculita
Comment 3 2012-11-07 13:31:39 PST
Landed in http://trac.webkit.org/changeset/133803 .
Note You need to log in before you can comment on or make changes to this bug.