Bug 100905

Summary: CoordinatedGraphicsArgumentCoders should use ValidatedCustomFitlerOperation instead
Product: WebKit Reporter: Alexandru Chiculita <achicu>
Component: WebKit2Assignee: Alexandru Chiculita <achicu>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, dongseong.hwang, mvujovic, noam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 100533, 100906    
Bug Blocks: 74651, 98990, 101071    
Attachments:
Description Flags
Patch V1 noam: review+, noam: commit-queue-

Alexandru Chiculita
Reported 2012-10-31 17:25:15 PDT
CoordinatedGraphicsArgumentCoders uses the CustomFilterOperation, but it will never receive it anymore. It needs to be updated to use the ValidatedCustomFilterOperation instead.
Attachments
Patch V1 (8.14 KB, patch)
2012-11-02 13:41 PDT, Alexandru Chiculita 		noam: review+
noam: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dongseong Hwang
Comment 1 2012-11-01 16:35:30 PDT
Thank you for filing this bug. I can do it. Could I do?
Alexandru Chiculita
Comment 2 2012-11-02 13:41:04 PDT
Created attachment 172128 [details] Patch V1
Noam Rosenthal
Comment 3 2012-11-02 16:04:43 PDT
Comment on attachment 172128 [details] Patch V1 View in context: https://bugs.webkit.org/attachment.cgi?id=172128&action=review LGTM > Source/WebCore/platform/graphics/filters/CustomFilterValidatedProgram.h:83 > + const String& validatedVertexShader() const { ASSERT(m_isInitialized); return m_validatedVertexShader; } > + const String& validatedFragmentShader() const { ASSERT(m_isInitialized); return m_validatedFragmentShader; } These functions deserve some more line breaks :)
Alexandru Chiculita
Comment 4 2012-11-07 10:30:11 PST
Landed manually in http://trac.webkit.org/changeset/133777.
Note You need to log in before you can comment on or make changes to this bug.