COMMIT_MESSAGE

AX: iOS VO+Safari does not read <summary> role or state 

https://bugs.webkit.org/show_bug.cgi?id=257162

rdar://109684906

Reviewed by NOBODY (OOPS!).

This patch fixes the calculation for AccessibilityObject::supportsExpanded() so that <summary> elements

describe their state when using iOS voiceover. For <details> elements, we cannot rely on checking the

aria-expanded attribute since that does not exist on details elements (the attribute 'open' is used instead).

This affects <summary> elements as they use their <detail> parents to calculate accessibilitySupportsARIAExpanded().

iOS AX tests were also added to confirm that this is the case.

* Source/WebCore/accessibility/AccessibilityObject.cpp:

Update AccessibilityObject::supportsExpanded().

* Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

* Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:

* Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:

* Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:

Expose method for testing.

* LayoutTests/accessibility/ios-simulator/aria-details-toggle-summary-expected.txt:

* LayoutTests/accessibility/ios-simulator/aria-details-toggle-summary.html:

New test for checking isExpanded, supportsExpanded.

Source/WebCore/accessibility/AccessibilityObject.cpp

@@bool AccessibilityObject::supportsExpanded() const

        return true;

    switch (roleValue()) {

3360 case AccessibilityRole::Details:

3361 return true;

    case AccessibilityRole::Button:

    case AccessibilityRole::CheckBox:

    case AccessibilityRole::ColumnHeader:

    case AccessibilityRole::ComboBox:

3364 case AccessibilityRole::Details:

    case AccessibilityRole::DisclosureTriangle:

    case AccessibilityRole::GridCell:

    case AccessibilityRole::Link:

Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp

@@bool AccessibilityUIElement::isInTable() const { return false; }

bool AccessibilityUIElement::isInLandmark() const { return false; }

bool AccessibilityUIElement::isInList() const { return false; }

bool AccessibilityUIElement::isMarkAnnotation() const { return false; }

97bool AccessibilityUIElement::supportsExpanded() const { return false; }

#endif

// Unsupported methods on various platforms. As they're implemented on other platforms this list should be modified.

Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h

@@public:

    
    bool isValid() const;

    bool isExpanded() const;

203 bool supportsExpanded() const;

    bool isChecked() const;

    JSRetainPtr<JSStringRef> currentStateValue() const;

    JSRetainPtr<JSStringRef> sortDirection() const;

Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl

    readonly attribute boolean isSearchField;

    readonly attribute boolean isTextArea;

    readonly attribute boolean isMarkAnnotation;

307 readonly attribute boolean supportsExpanded;

    readonly attribute boolean hasDocumentRoleAncestor;

    readonly attribute boolean hasWebApplicationAncestor;

Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm

@@- (BOOL)_accessibilityHasTouchEventListener;

- (NSString *)accessibilityExpandedTextValue;

- (NSString *)accessibilitySortDirection;

- (BOOL)accessibilityIsExpanded;

101- (BOOL)accessibilitySupportsARIAExpanded;

- (BOOL)accessibilityIsIndeterminate;

- (NSUInteger)accessibilityBlockquoteLevel;

- (NSArray *)accessibilityFindMatchingObjects:(NSDictionary *)parameters;

@@bool AccessibilityUIElement::isExpanded() const

    return [m_element accessibilityIsExpanded];

}

bool AccessibilityUIElement::supportsExpanded() const

{

    return [m_element accessibilitySupportsARIAExpanded];

}

bool AccessibilityUIElement::isChecked() const

{

    return false;

LayoutTests/accessibility/ios-simulator/aria-details-toggle-summary-expected.txt

This verifies that the summary of a details element has the right isExpanded value.

PASS: summaryElement.supportsExpanded === true

PASS: summaryElement.isExpanded === true

PASS: summaryElement.isExpanded === false

PASS successfullyParsed is true

TEST COMPLETE

Details example

LayoutTests/accessibility/ios-simulator/aria-details-toggle-summary.html

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

<html>

<head>

<script src="../../resources/accessibility-helper.js"></script>

<script src="../../resources/js-test.js"></script>

</head>

<body>

<details open id="details1">

    <summary id="summary1">Details example</summary>

    <p>

    This is some description, hidden when the details element is collapsed. 

    </p>

</details>

<script>

    var result = "This verifies that the summary of a details element has the right isExpanded value.\n\n";

    if (window.accessibilityController) {

        window.jsTestIsAsync = true;

        var summaryElement = accessibilityController.accessibleElementById("summary1");

        setTimeout(async () => {

            result += expect("summaryElement.supportsExpanded", "true")

            result += expect("summaryElement.isExpanded", "true");

            document.getElementById("details1").toggleAttribute("open");

            result += await expectAsync("summaryElement.isExpanded", "false");

            debug(result);

            finishJSTest();

        }, 0);

    }

</script>

</body>

</html>