ChangeLog

2019-12-01  Caio Lima  <ticaiolima@gmail.com>

        [32-bits] Check if StructureStubInfo::patch.baseTagGPR is used somewhere.

        https://bugs.webkit.org/show_bug.cgi?id=204726

        Reviewed by NOBODY (OOPS!).

         When we generate ByIdInlineCache and ByValInlineCache, `base` is always

         a cell. Given that, we don't need to store `baseTag` on 32-bits

         version. This patch is removing StructureStubInfo::patch.baseTagGPR.

        * bytecode/AccessCase.cpp:

        (JSC::AccessCase::generateImpl):

        * bytecode/GetterSetterAccessCase.cpp:

        (JSC::GetterSetterAccessCase::emitDOMJITGetter):

        * bytecode/InlineAccess.cpp:

        (JSC::getScratchRegister):

        * bytecode/PolymorphicAccess.cpp:

        (JSC::PolymorphicAccess::regenerate):

        * bytecode/StructureStubInfo.h:

        * jit/JITInlineCacheGenerator.cpp:

        (JSC::JITByIdGenerator::JITByIdGenerator):

        (JSC::JITInstanceOfGenerator::JITInstanceOfGenerator):

2019-11-29  Eike Rathke  <erack@redhat.com>

        Use default implementation for JSVALUE64 with GCC on unknown platform.

Source/JavaScriptCore/bytecode/AccessCase.cpp

@@void AccessCase::generateImpl(AccessGenerationState& state)

        ScratchRegisterAllocator allocator(stubInfo.patch.usedRegisters);

        allocator.lock(baseGPR);

#if USE(JSVALUE32_64)

        allocator.lock(stubInfo.patch.baseTagGPR);

#endif

        allocator.lock(valueRegs);

        allocator.lock(scratchGPR);

Source/JavaScriptCore/bytecode/GetterSetterAccessCase.cpp

@@void GetterSetterAccessCase::emitDOMJITGetter(AccessGenerationState& state, cons

    ScratchRegisterAllocator allocator(stubInfo.patch.usedRegisters);

    allocator.lock(baseGPR);

#if USE(JSVALUE32_64)

    allocator.lock(stubInfo.patch.baseTagGPR);

#endif

    allocator.lock(valueRegs);

    allocator.lock(scratchGPR);

Source/JavaScriptCore/bytecode/InlineAccess.cpp

@@ALWAYS_INLINE static GPRReg getScratchRegister(StructureStubInfo& stubInfo)

    allocator.lock(stubInfo.baseGPR());

    allocator.lock(stubInfo.patch.valueGPR);

#if USE(JSVALUE32_64)

216 allocator.lock(stubInfo.patch.baseTagGPR);

    allocator.lock(stubInfo.patch.valueTagGPR);

#endif

    GPRReg scratch = allocator.allocateScratchGPR();

Source/JavaScriptCore/bytecode/PolymorphicAccess.cpp

@@AccessGenerationResult PolymorphicAccess::regenerate(

    if (state.u.thisGPR != InvalidGPRReg)

        allocator.lock(state.u.thisGPR);

    allocator.lock(state.valueRegs);

#if USE(JSVALUE32_64)

    allocator.lock(stubInfo.patch.baseTagGPR);

#endif

    state.scratchGPR = allocator.allocateScratchGPR();

Source/JavaScriptCore/bytecode/StructureStubInfo.h

@@public:

        } u;

#if USE(JSVALUE32_64)

        GPRReg valueTagGPR;

223 GPRReg baseTagGPR;

        GPRReg thisTagGPR;

#endif

    } patch;

Source/JavaScriptCore/jit/JITInlineCacheGenerator.cpp

@@JITByIdGenerator::JITByIdGenerator(

    m_stubInfo->patch.valueGPR = value.payloadGPR();

    m_stubInfo->patch.u.thisGPR = InvalidGPRReg;

#if USE(JSVALUE32_64)

79 m_stubInfo->patch.baseTagGPR = base.tagGPR();

    m_stubInfo->patch.valueTagGPR = value.tagGPR();

    m_stubInfo->patch.thisTagGPR = InvalidGPRReg;

#endif

@@JITInstanceOfGenerator::JITInstanceOfGenerator(

    m_stubInfo->patch.valueGPR = result;

    m_stubInfo->patch.u.prototypeGPR = prototype;

#if USE(JSVALUE32_64)

191 m_stubInfo->patch.baseTagGPR = InvalidGPRReg;

    m_stubInfo->patch.valueTagGPR = InvalidGPRReg;

    m_stubInfo->patch.thisTagGPR = InvalidGPRReg;

#endif