COMMIT_MESSAGE

1Version 1 only

2

JSTests/ChangeLog

2017-05-11  JF Bastien  <jfbastien@apple.com>

        WebAssembly: stop supporting 0xD

        https://bugs.webkit.org/show_bug.cgi?id=168788

        <rdar://problem/31880922>

        Reviewed by NOBODY (OOPS!).

        Test that only version 1 is supported.

        * wasm/js-api/version.js: Added.

2017-05-10  JF Bastien  <jfbastien@apple.com>

        WebAssemby: builder doesn't do Memory section maximum correctly

JSTests/wasm/js-api/version.js

import * as assert from '../assert.js';

import * as utilities from '../utilities.js';

for (let version = 0; version < 256; ++version) {

    if (version === 1)

        continue;

    const emptyModuleArray = Uint8Array.of(0x0, 0x61, 0x73, 0x6d, version, 0x00, 0x00, 0x00);

    assert.throws(() => new WebAssembly.Module(emptyModuleArray), WebAssembly.CompileError, `WebAssembly.Module doesn't parse at byte 8 / 8: unexpected version number ${version} expected 1`);

}

Source/JavaScriptCore/ChangeLog

2017-05-11  JF Bastien  <jfbastien@apple.com>

        WebAssembly: stop supporting 0xD

        https://bugs.webkit.org/show_bug.cgi?id=168788

        <rdar://problem/31880922>

        Reviewed by NOBODY (OOPS!).

        Only version 1 is supported by other browsers, and there shouldn't

        be any 0xD binaries in the wild anymore.

        * wasm/WasmModuleParser.cpp:

2017-05-09  Sam Weinig  <sam@webkit.org>

        Remove support for legacy Notifications

Source/JavaScriptCore/wasm/WasmModuleParser.cpp

1

/*

 * Copyright (C) 2016-2017 Apple Inc. All rights reserved.

 *

@@auto ModuleParser::parse() -> Result

    WASM_PARSER_FAIL_IF(length() < minSize, "expected a module of at least ", minSize, " bytes");

    WASM_PARSER_FAIL_IF(!consumeCharacter(0) || !consumeString("asm"), "modules doesn't start with '\\0asm'");

    WASM_PARSER_FAIL_IF(!parseUInt32(versionNumber), "can't parse version number");

56 if (versionNumber != 0xD) // FIXME Stop supporting version 0xD temporarily. https://bugs.webkit.org/show_bug.cgi?id=168788

57 WASM_PARSER_FAIL_IF(versionNumber != expectedVersionNumber, "unexpected version number ", versionNumber, " expected ", expectedVersionNumber);

    Section previousSection = Section::Custom;

    while (m_offset < length()) {