ChangeLog

2017-04-20  Gwang Yoon Hwang  <yoon@igalia.com>

        Do not paint the border of the box if the dirty region does not intersect with border area

        https://bugs.webkit.org/show_bug.cgi?id=170988

        Reviewed by Simon Fraser.

        No new tests, since there is no change in behavior.

        * platform/graphics/GeometryUtilities.cpp:

        (WebCore::ellipseContainsPoint):

        Checks if a point is within an ellipse.

        * platform/graphics/GeometryUtilities.h:

        Replace header-guards with #pragma once.

        * platform/graphics/RoundedRect.cpp:

        (WebCore::RoundedRect::contains):

        Implemented to know the dirty rectangle intersects with rounded rectangle or not.

        * platform/graphics/RoundedRect.h:

        * rendering/RenderBoxModelObject.cpp:

        (WebCore::RenderBoxModelObject::paintBorder):

        When typing in decorated text box, the dirty rect generated only for the

        inside of the text box, not for the decorations.  So we can avoid the

        calculations to draw borders if the inner border totally covers the

        target surface. It will optimize the rendering process since we don't

        have to render border decorations whenever we type somethings in side of

        the text input element.

2017-04-21  Alex Christensen  <achristensen@webkit.org>

        Reduce copies and allocations in SharedBuffer::append

Source/WebCore/platform/graphics/GeometryUtilities.cpp

@@FloatRect smallestRectWithAspectRatioAroundRect(float aspectRatio, const FloatRe

    return destRect;

}

bool ellipseContainsPoint(const FloatPoint& center, const FloatSize& radii, const FloatPoint& point)

{

    FloatPoint transformedPoint(point);

    transformedPoint.move(-center.x(), -center.y());

    transformedPoint.scale(radii.height(), radii.width());

    float radius = radii.width() * radii.height();

    if (transformedPoint.x() > radius || transformedPoint.y() > radius)

        return false;

    if (transformedPoint.x() + transformedPoint.y() <= radius)

        return true;

    return (transformedPoint.lengthSquared() <= radius * radius);

}

149163}

Source/WebCore/platform/graphics/GeometryUtilities.h

 * THE POSSIBILITY OF SUCH DAMAGE.

 */

26 #ifndef GeometryUtilities_h

27 #define GeometryUtilities_h

26#pragma once

#include "FloatRect.h"

#include "IntRect.h"

@@WEBCORE_EXPORT FloatRect smallestRectWithAspectRatioAroundRect(float aspectRatio

// Compute a rect that encloses all points covered by the given rect if it were rotated a full turn around (0,0).

FloatRect boundsOfRotatingRect(const FloatRect&);

53bool ellipseContainsPoint(const FloatPoint& center, const FloatSize& radii, const FloatPoint&);

5454}

55

56 #endif // GeometryUtilities_h

Source/WebCore/platform/graphics/RoundedRect.cpp

#include "RoundedRect.h"

#include "FloatRoundedRect.h"

32#include "GeometryUtilities.h"

#include "LayoutRect.h"

#include "LayoutUnit.h"

@@bool RoundedRect::intersectsQuad(const FloatQuad& quad) const

    return true;

}

bool RoundedRect::contains(const LayoutRect& otherRect) const

{

    if (!rect().contains(otherRect))

        return false;

    const LayoutSize& topLeft = m_radii.topLeft();

    if (!topLeft.isEmpty()) {

        FloatPoint center = { m_rect.x() + topLeft.width(), m_rect.y() + topLeft.height() };

        if (otherRect.x() <= center.x() && otherRect.y() <= center.y()) {

            if (!ellipseContainsPoint(center, topLeft, otherRect.location()))

                return false;

        }

    }

    const LayoutSize& topRight = m_radii.topRight();

    if (!topRight.isEmpty()) {

        FloatPoint center = { m_rect.maxX() - topRight.width(), m_rect.y() + topRight.height() };

        if (otherRect.maxX() >= center.x() && otherRect.y() <= center.y()) {

            if (!ellipseContainsPoint(center, topRight, otherRect.location()))

                return false;

        }

    }

    const LayoutSize& bottomLeft = m_radii.bottomLeft();

    if (!bottomLeft.isEmpty()) {

        FloatPoint center = { m_rect.x() + bottomLeft.width(), m_rect.maxY() - bottomLeft.height() };

        if (otherRect.maxX() >= center.x() && otherRect.maxY() >= center.y()) {

            if (!ellipseContainsPoint(center, bottomLeft, otherRect.location()))

                return false;

        }

    }

    const LayoutSize& bottomRight = m_radii.bottomRight();

    if (!bottomRight.isEmpty()) {

        FloatPoint center = { m_rect.maxX() - bottomRight.width(), m_rect.maxY() - bottomRight.height() };

        if (otherRect.x() <= center.x() && otherRect.maxY() >= center.y()) {

            if (!ellipseContainsPoint(center, bottomRight, otherRect.location()))

                return false;

        }

    }

    return true;

}

FloatRoundedRect RoundedRect::pixelSnappedRoundedRectForPainting(float deviceScaleFactor) const

{

    LayoutRect originalRect = rect();

Source/WebCore/platform/graphics/RoundedRect.h

@@public:

    // Tests whether the quad intersects any part of this rounded rectangle.

    // This only works for convex quads.

    bool intersectsQuad(const FloatQuad&) const;

109 bool contains(const LayoutRect&) const;

    FloatRoundedRect pixelSnappedRoundedRectForPainting(float deviceScaleFactor) const;

Source/WebCore/rendering/RenderBoxModelObject.cpp

@@void RenderBoxModelObject::paintBorder(const PaintInfo& info, const LayoutRect&

    RoundedRect outerBorder = style.getRoundedBorderFor(rect, includeLogicalLeftEdge, includeLogicalRightEdge);

    RoundedRect innerBorder = style.getRoundedInnerBorderFor(borderInnerRectAdjustedForBleedAvoidance(graphicsContext, rect, bleedAvoidance), includeLogicalLeftEdge, includeLogicalRightEdge);

    // If no borders intersects with the dirty area, we can skip the border painting.

    if (innerBorder.contains(info.rect))

        return;

    bool haveAlphaColor = false;

    bool haveAllSolidEdges = true;

    bool haveAllDoubleEdges = true;