Tools/ChangeLog

 12017-01-30 Carlos Alberto Lopez Perez <clopez@igalia.com>
 2
 3 run-perf-tests timeout settings broken
 4 https://bugs.webkit.org/show_bug.cgi?id=167626
 5
 6 Reviewed by NOBODY (OOPS!).
 7
 8 The --time-out-ms value (defaults to 600 seconds) of run-perf-tests
 9 was beeing ignored because the driver was created with no_timeout=True
 10 unconditionally.
 11 This adds a new parameter --no-timeout (disabled by default), that
 12 allows to use the driver with the expected timeout values.
 13
 14 * Scripts/webkitpy/performance_tests/perftest.py:
 15 (PerfTest._create_driver): Only disable timeout if --no-timeout is passed.
 16 (PerfTest.run):
 17 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
 18 (PerfTestsRunner._parse_args): Add a --no-timeout parameter.
 19 (_run_tests_set):
 20
1212017-01-30 Myles C. Maxfield <mmaxfield@apple.com>
222
323 Correct spacing regression on inter-element complex path shaping on some fonts

Tools/Scripts/webkitpy/performance_tests/perftest.py

@@class PerfTest(object):
122122 def prepare(self, time_out_ms):
123123 return True
124124
125  def _create_driver(self):
126  return self._port.create_driver(worker_number=0, no_timeout=True)
 125 def _create_driver(self, no_timeout):
 126 return self._port.create_driver(worker_number=0, no_timeout=no_timeout)
127127
128  def run(self, time_out_ms):
 128 def run(self, time_out_ms, no_timeout=False):
129129 for _ in xrange(self._test_runner_count):
130  driver = self._create_driver()
 130 driver = self._create_driver(no_timeout)
131131 try:
132132 if not self._run_with_driver(driver, time_out_ms):
133133 return None

Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py

@@class PerfTestsRunner(object):
100100 help="Path to the directory under which build files are kept (should not include configuration)"),
101101 optparse.make_option("--time-out-ms", default=600 * 1000,
102102 help="Set the timeout for each test"),
 103 optparse.make_option("--no-timeout", action="store_true", default=False,
 104 help="Disable test timeouts"),
103105 optparse.make_option("--no-results", action="store_false", dest="generate_results", default=True,
104106 help="Do no generate results JSON and results page."),
105107 optparse.make_option("--output-json-path", action='callback', callback=_expand_path, type="str",

@@class PerfTestsRunner(object):
375377 for i, test in enumerate(tests):
376378 _log.info('Running %s (%d of %d)' % (test.test_name(), i + 1, len(tests)))
377379 start_time = time.time()
378  metrics = test.run(self._options.time_out_ms)
 380 metrics = test.run(self._options.time_out_ms, self._options.no_timeout)
 381
379382 if metrics:
380383 self._results += metrics
381384 else: