Attachment 52604 Details for Bug 37135 – (committed in r57211) patch

[patch] (committed in r57211) patch

0001-Spatial-Navigation-bail-out-as-soon-as-algorithm-fi.patch (text/plain), 2.54 KB, created by Antonio Gomes on 2010-04-05 21:40:33 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Antonio Gomes

Created: 2010-04-05 21:40:33 PDT

Size: 2.54 KB

patch

obsolete

>From f86f70acc5b3a5e8a140de0ef36084ccad29bacf Mon Sep 17 00:00:00 2001
>From: Antonio Gomes <tonikitoo@webkit.org>
>Date: Tue, 6 Apr 2010 00:36:30 -0400
>Subject: [PATCH] Spatial Navigation: bail out as soon as algorithm finds a focus candidate is not applicable
> https://bugs.webkit.org/show_bug.cgi?id=37135
>
>Reviewed by NOBODY (OOPS!).
>Patch by Antonio Gomes <tonikitoo@webkit.org>
>
>It happens, for example, when distanceDataForNode assigns numeric_limits<long long> to
>current focus candidate's. It means that current candidate is not in direction, or not
>a valid target node.
>
>* page/FocusController.cpp:
>(WebCore::FocusController::findFocusableNodeInDirection):
>---
> WebCore/ChangeLog                |   14 ++++++++++++++
> WebCore/page/FocusController.cpp |    4 ++++
> 2 files changed, 18 insertions(+), 0 deletions(-)
>
>diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
>index 8b65876..71cf549 100644
>--- a/WebCore/ChangeLog
>+++ b/WebCore/ChangeLog
>@@ -2,6 +2,20 @@
> 
>         Reviewed by NOBODY (OOPS!).
> 
>+        Spatial Navigation: bail out as soon as algorithm finds a focus candidate is not applicable
>+        https://bugs.webkit.org/show_bug.cgi?id=37135
>+
>+        It happens, for example, when distanceDataForNode assigns numeric_limits<long long> to
>+        current focus candidate's. It means that current candidate is not in direction, or not
>+        a valid target node.
>+
>+        * page/FocusController.cpp:
>+        (WebCore::FocusController::findFocusableNodeInDirection):
>+
>+2010-04-05  Antonio Gomes  <tonikitoo@webkit.org>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>         Spatial Navigation: make it work with focusable elements in overflow content
>         https://bugs.webkit.org/show_bug.cgi?id=36463
> 
>diff --git a/WebCore/page/FocusController.cpp b/WebCore/page/FocusController.cpp
>index 37b72af..985520e 100644
>--- a/WebCore/page/FocusController.cpp
>+++ b/WebCore/page/FocusController.cpp
>@@ -434,6 +434,10 @@ void FocusController::findFocusableNodeInDirection(Document* document, Node* foc
>             // Get distance and alignment from current candidate.
>             distanceDataForNode(direction, focusedNode, currentFocusCandidate);
> 
>+            // Bail out if distance is maximum.
>+            if (currentFocusCandidate.distance == maxDistance())
>+                continue;
>+
>             // If candidateParent is not null, it means that we are in a recursive call
>             // from deepFineFocusableNodeInDirection (i.e. processing an element in an iframe),
>             // and holds the distance and alignment data of the iframe element itself.
>-- 
>1.6.0.4
>

Actions: View | Formatted Diff | Diff

Attachments on bug 37135: 52604