Attachment #382682 for bug #203776

View Details Raw Unified Return to Bug 203776



2019-11-02  Simon Fraser  <simon.fraser@apple.com>

        "ValueError('too many values to unpack') raised:" on imported css-backgrounds tests
        https://bugs.webkit.org/show_bug.cgi?id=203776

        Reviewed by NOBODY (OOPS!).

        A few directories (including not-yet-imported css-backgrounds wpt) contain
        the obsolete reftest.list files. These need to be deprecated (webkit.org/b/203783)
        but for now, only support them in the two directories that need them. Newly
        imported wpt should never use them, and the ones in css-backgrounds have a slightly different
        format that this parser fails on.

        * Scripts/webkitpy/port/base.py:
        (Port._parse_reftest_list):

2019-11-01  Jonathan Bedard  <jbedard@apple.com>

        Python 3: Add support in webkitpy.layout_tests.model

Lines 517-522 class Port(object): a/Tools/Scripts/webkitpy/port/base.py_sec1
- a/Tools/Scripts/webkitpy/port/base.py +8 lines
517	reftest_list_path = filesystem.join(test_dirpath, 'reftest.list')	517	reftest_list_path = filesystem.join(test_dirpath, 'reftest.list')
518	if not filesystem.isfile(reftest_list_path):	518	if not filesystem.isfile(reftest_list_path):
519	return None	519	return None
		520
		521	# FIXME: We should stop parsing reftest.list files. Only two directories need them: webkit.org/b/203783
		522	encoding_tests_subpath = os.path.join('imported', 'w3c', 'web-platform-tests', 'encoding')
		523	webvtt_tests_subpath = os.path.join('media', 'track', 'opera', 'track', 'webvtt', 'rendering', 'reftest')
		524	if encoding_tests_subpath not in test_dirpath and webvtt_tests_subpath not in test_dirpath:
		525	_log.debug("Ignoring reftest.list file in {}".format(reftest_list_path))
		526	return None
		527
520	reftest_list_file = filesystem.read_text_file(reftest_list_path)	528	reftest_list_file = filesystem.read_text_file(reftest_list_path)
521		529
522	parsed_list = {}	530	parsed_list = {}

Return to Bug 203776

Lines 1-3 a/Tools/ChangeLog_sec1
- a/Tools/ChangeLog +16 lines
		1	2019-11-02 Simon Fraser <simon.fraser@apple.com>
		2
		3	"ValueError('too many values to unpack') raised:" on imported css-backgrounds tests
		4	https://bugs.webkit.org/show_bug.cgi?id=203776
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	A few directories (including not-yet-imported css-backgrounds wpt) contain
		9	the obsolete reftest.list files. These need to be deprecated (webkit.org/b/203783)
		10	but for now, only support them in the two directories that need them. Newly
		11	imported wpt should never use them, and the ones in css-backgrounds have a slightly different
		12	format that this parser fails on.
		13
		14	* Scripts/webkitpy/port/base.py:
		15	(Port._parse_reftest_list):
		16
1	2019-11-01 Jonathan Bedard <jbedard@apple.com>	17	2019-11-01 Jonathan Bedard <jbedard@apple.com>
2		18
3	Python 3: Add support in webkitpy.layout_tests.model	19	Python 3: Add support in webkitpy.layout_tests.model